From: Anthony Liguori <anthony@codemonkey.ws>
To: Glauber Costa <glommer@redhat.com>
Cc: Dor Laor <dlaor@redhat.com>, Uri Lublin <uril@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ram_save_live: add a no-progress convergence rule
Date: Tue, 19 May 2009 13:17:57 -0500 [thread overview]
Message-ID: <4A12F7D5.7050608@codemonkey.ws> (raw)
In-Reply-To: <20090519150927.GB16372@shell.devel.redhat.com>
Glauber Costa wrote:
> On Tue, May 19, 2009 at 05:59:14PM +0300, Dor Laor wrote:
>
>
>> We can also make it configurable using the monitor migrate command. For
>> example:
>> migrate -d -no_progress -threshold=x tcp:....
>>
> it can be done, but it fits better as a different monitor command
>
> anthony, do you have any strong opinions here, or is this scheme acceptable?
>
Threshold is a bad metric. There's no way to choose a right number. If
we were going to have a means to support metrics-based forced
convergence (and I really think this belongs in libvirt) I'd rather see
something based on bandwidth or wall clock time.
Let me put it this way, why 50? What were the guidelines for choosing
that number and how would you explain what number a user should choose?
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-05-19 18:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 11:09 [Qemu-devel] [PATCH] ram_save_live: add a no-progress convergence rule Uri Lublin
2009-05-19 13:00 ` Anthony Liguori
2009-05-19 14:41 ` Glauber Costa
2009-05-19 14:59 ` Dor Laor
2009-05-19 15:09 ` Glauber Costa
2009-05-19 18:17 ` Anthony Liguori [this message]
2009-05-20 16:56 ` Uri Lublin
2009-05-20 17:28 ` Blue Swirl
2009-05-20 17:34 ` Uri Lublin
2009-05-19 18:19 ` Anthony Liguori
2009-05-19 18:15 ` Anthony Liguori
2009-05-20 17:17 ` Uri Lublin
2009-05-19 18:09 ` Anthony Liguori
2009-05-20 17:25 ` Uri Lublin
2009-05-20 17:15 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A12F7D5.7050608@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=dlaor@redhat.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=uril@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).