From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M6TtB-0000J6-KB
	for qemu-devel@nongnu.org; Tue, 19 May 2009 14:18:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M6Tt6-0000DB-UT
	for qemu-devel@nongnu.org; Tue, 19 May 2009 14:18:09 -0400
Received: from [199.232.76.173] (port=42973 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M6Tt6-0000D5-J9
	for qemu-devel@nongnu.org; Tue, 19 May 2009 14:18:04 -0400
Received: from rv-out-0708.google.com ([209.85.198.250]:37144)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1M6Tt6-0002T5-4u
	for qemu-devel@nongnu.org; Tue, 19 May 2009 14:18:04 -0400
Received: by rv-out-0708.google.com with SMTP id c5so2343469rvf.22
	for <qemu-devel@nongnu.org>; Tue, 19 May 2009 11:18:02 -0700 (PDT)
Message-ID: <4A12F7D5.7050608@codemonkey.ws>
Date: Tue, 19 May 2009 13:17:57 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] ram_save_live: add a no-progress convergence
	rule
References: <1242731347-1558-1-git-send-email-uril@redhat.com>
	<4A12AD80.701@codemonkey.ws>
	<20090519144101.GA16372@shell.devel.redhat.com>
	<4A12C942.4090708@redhat.com>
	<20090519150927.GB16372@shell.devel.redhat.com>
In-Reply-To: <20090519150927.GB16372@shell.devel.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: Dor Laor <dlaor@redhat.com>, Uri Lublin <uril@redhat.com>, qemu-devel@nongnu.org

Glauber Costa wrote:
> On Tue, May 19, 2009 at 05:59:14PM +0300, Dor Laor wrote:
>   
>
>> We can also make it configurable using the monitor migrate command. For 
>> example:
>> migrate -d -no_progress -threshold=x tcp:....
>>     
> it can be done, but it fits better as a different monitor command
>
> anthony, do you have any strong opinions here, or is this scheme acceptable?
>   

Threshold is a bad metric.  There's no way to choose a right number.  If 
we were going to have a means to support metrics-based forced 
convergence (and I really think this belongs in libvirt) I'd rather see 
something based on bandwidth or wall clock time.

Let me put it this way, why 50?  What were the guidelines for choosing 
that number and how would you explain what number a user should choose?

Regards,

Anthony Liguori