From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M6jSh-0001A6-Ek for qemu-devel@nongnu.org; Wed, 20 May 2009 06:55:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M6jSc-00019B-1N for qemu-devel@nongnu.org; Wed, 20 May 2009 06:55:50 -0400 Received: from [199.232.76.173] (port=52607 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6jSb-000197-Rt for qemu-devel@nongnu.org; Wed, 20 May 2009 06:55:45 -0400 Received: from mx2.redhat.com ([66.187.237.31]:34591) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M6jSb-0005bi-9u for qemu-devel@nongnu.org; Wed, 20 May 2009 06:55:45 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4KAtiF8003148 for ; Wed, 20 May 2009 06:55:44 -0400 Message-ID: <4A13E1AD.6030603@redhat.com> Date: Wed, 20 May 2009 13:55:41 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qcow2: Allow different cluster sizes References: <1242748641-4294-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1242748641-4294-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Kevin Wolf wrote: > Add an option to specify the cluster size of a newly created qcow2 image. > Default is 4k which is the same value that was hard-coded before. > I did an autotest run with 64K clusters, and everything seems to work fine. I think we should change the default to 64K; this both improves performance and reduces memory utilization for large disks. -- error compiling committee.c: too many arguments to function