From: Jan Kiszka <jan.kiszka@web.de>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH STABLE 2/2] net: Fix -net socket parameter checks
Date: Thu, 21 May 2009 08:23:22 +0200 [thread overview]
Message-ID: <4A14F35A.6070400@web.de> (raw)
In-Reply-To: <1242866670-15488-3-git-send-email-glommer@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
Glauber Costa wrote:
> My commit ea053add700d8abe203cd79a9ffb082aee4eabc0 broke -net socket by
> overwriting an intermediate buffer in the added check_param. Fix this
> by switching check_param to automatic buffer allocation and release, ie.
> callers no longer have to worry about providing a scratch buffer.
That commit was buggy, too, and is awaiting to be fixed in unstable by
http://permalink.gmane.org/gmane.comp.emulators.qemu/43041.
But more importantly, it makes no sense in stable because its "heart",
param checking for -net is only in unstable (and that's perfectly fine).
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2009-05-21 6:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 0:44 [Qemu-devel] [PATCH STABLE 0/2] Backport -net socket fixes Glauber Costa
2009-05-21 0:44 ` [Qemu-devel] [PATCH STABLE 1/2] net: Fix -net socket, listen (Jan Kiszka) Glauber Costa
2009-05-21 0:44 ` [Qemu-devel] [PATCH STABLE 2/2] net: Fix -net socket parameter checks Glauber Costa
2009-05-21 6:23 ` Jan Kiszka [this message]
2009-05-21 12:12 ` [Qemu-devel] " Glauber Costa
2009-05-21 16:26 ` Jan Kiszka
2009-05-21 16:38 ` Glauber Costa
2009-05-21 16:45 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A14F35A.6070400@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).