From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M71go-0008Oz-Jn for qemu-devel@nongnu.org; Thu, 21 May 2009 02:23:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M71gg-0008OT-TC for qemu-devel@nongnu.org; Thu, 21 May 2009 02:23:37 -0400 Received: from [199.232.76.173] (port=51054 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M71gg-0008OQ-Od for qemu-devel@nongnu.org; Thu, 21 May 2009 02:23:30 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:54978) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M71gg-0004ng-7c for qemu-devel@nongnu.org; Thu, 21 May 2009 02:23:30 -0400 Message-ID: <4A14F35A.6070400@web.de> Date: Thu, 21 May 2009 08:23:22 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1242866670-15488-1-git-send-email-glommer@redhat.com> <1242866670-15488-2-git-send-email-glommer@redhat.com> <1242866670-15488-3-git-send-email-glommer@redhat.com> In-Reply-To: <1242866670-15488-3-git-send-email-glommer@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigAFB6ED86DDA7AAE4310769CC" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH STABLE 2/2] net: Fix -net socket parameter checks List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAFB6ED86DDA7AAE4310769CC Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Glauber Costa wrote: > My commit ea053add700d8abe203cd79a9ffb082aee4eabc0 broke -net socket by= > overwriting an intermediate buffer in the added check_param. Fix this > by switching check_param to automatic buffer allocation and release, ie= =2E > callers no longer have to worry about providing a scratch buffer. That commit was buggy, too, and is awaiting to be fixed in unstable by http://permalink.gmane.org/gmane.comp.emulators.qemu/43041. But more importantly, it makes no sense in stable because its "heart", param checking for -net is only in unstable (and that's perfectly fine). Jan --------------enigAFB6ED86DDA7AAE4310769CC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkoU818ACgkQniDOoMHTA+lDZACeNcl/11JIE/DTbYS/ajPgFTea /awAn0s4Cx7gNlBf3Ue3gEz5B7C2UOk9 =qQHs -----END PGP SIGNATURE----- --------------enigAFB6ED86DDA7AAE4310769CC--