From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M75Sp-0001j8-Hn for qemu-devel@nongnu.org; Thu, 21 May 2009 06:25:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M75Sj-0001hV-E8 for qemu-devel@nongnu.org; Thu, 21 May 2009 06:25:25 -0400 Received: from [199.232.76.173] (port=53234 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M75Sj-0001hQ-8a for qemu-devel@nongnu.org; Thu, 21 May 2009 06:25:21 -0400 Received: from mx2.redhat.com ([66.187.237.31]:41360) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M75Si-0008P0-Nc for qemu-devel@nongnu.org; Thu, 21 May 2009 06:25:21 -0400 Message-ID: <4A152B8D.5020006@redhat.com> Date: Thu, 21 May 2009 13:23:09 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api References: <20090520162130.GA22109@redhat.com> <200905211109.09844.paul@codesourcery.com> In-Reply-To: <200905211109.09844.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Carsten Otte , kvm@vger.kernel.org, "Michael S. Tsirkin" , Rusty Russell , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Christian Borntraeger Paul Brook wrote: > On Wednesday 20 May 2009, Michael S. Tsirkin wrote: > >> define api for allocating/setting up msi-x irqs, and for updating them >> with msi-x vector information, supply implementation in ioapic. Please >> comment on this API: I intend to port my msi-x patch to work on top of >> it. >> > > I though the point of MSI is that they are just a regular memory writes, and > don't require any special bus support. > The PCI bus doesn't need any special support (I think) but something on the other end needs to interpret those writes. In any case we need some internal API for this, and qemu_irq looks like a good choice. -- error compiling committee.c: too many arguments to function