From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M7775-0003ea-RN
	for qemu-devel@nongnu.org; Thu, 21 May 2009 08:11:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M7771-0003cF-88
	for qemu-devel@nongnu.org; Thu, 21 May 2009 08:11:07 -0400
Received: from [199.232.76.173] (port=50617 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M7771-0003bm-1e
	for qemu-devel@nongnu.org; Thu, 21 May 2009 08:11:03 -0400
Received: from mx2.redhat.com ([66.187.237.31]:44367)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1M776x-0000MM-Hb
	for qemu-devel@nongnu.org; Thu, 21 May 2009 08:11:00 -0400
Message-ID: <4A154432.1060808@redhat.com>
Date: Thu, 21 May 2009 15:08:18 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api
References: <20090520162130.GA22109@redhat.com>
	<200905211134.21184.paul@codesourcery.com>
	<4A15346C.8090906@redhat.com>
	<200905211301.52089.paul@codesourcery.com>
In-Reply-To: <200905211301.52089.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Christian Borntraeger <borntraeger@de.ibm.com>

Paul Brook wrote:
>>>> In any case we need some internal API for this, and qemu_irq looks like
>>>> a good choice.
>>>>         
>>> What do you expect to be using this API?
>>>       
>> virtio, emulated devices capable of supporting MSI (e1000?), device
>> assignment (not yet in qemu.git).
>>     
>
> It probably makes sense to have common infrastructure in pci.c to 
> expose/implement device side MSI functionality. However I see no need for a 
> direct API between the device and the APIC. We already have an API for memory 
> accesses and MMIO regions. I'm pretty sure a system could implement MSI by 
> pointing the device at system ram, and having the CPU periodically poll that.
>   

Instead of writing directly, let's abstract it behind a qemu_set_irq().  
This is easier for device authors.  The default implementation of the 
irq callback could write to apic memory, while for kvm we can directly 
trigger the interrupt via the kvm APIs.

-- 
error compiling committee.c: too many arguments to function