From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M78sq-00050z-Kf for qemu-devel@nongnu.org; Thu, 21 May 2009 10:04:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M78sm-0004z7-Sl for qemu-devel@nongnu.org; Thu, 21 May 2009 10:04:32 -0400 Received: from [199.232.76.173] (port=49040 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M78sm-0004yz-Ms for qemu-devel@nongnu.org; Thu, 21 May 2009 10:04:28 -0400 Received: from mx2.redhat.com ([66.187.237.31]:48728) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M78sl-0002h9-Tp for qemu-devel@nongnu.org; Thu, 21 May 2009 10:04:28 -0400 Message-ID: <4A155EC6.6070501@redhat.com> Date: Thu, 21 May 2009 17:01:42 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qemu: msi irq allocation api References: <20090520162130.GA22109@redhat.com> <200905211423.20843.paul@codesourcery.com> <20090521134650.GI25309@redhat.com> <200905211453.14691.paul@codesourcery.com> In-Reply-To: <200905211453.14691.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Carsten Otte , kvm@vger.kernel.org, "Michael S. Tsirkin" , Rusty Russell , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Christian Borntraeger Paul Brook wrote: >>> which is a trivial wrapper around stl_phys. >>> >> OK, but I'm adding another level of indirection in the middle, >> to allow us to tie in a kvm backend. >> > > kvm has no business messing with the PCI device code. > kvm has a fast path for irq injection. If qemu wants to support it we need some abstraction here. -- error compiling committee.c: too many arguments to function