From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M79iu-0001WM-Hj for qemu-devel@nongnu.org; Thu, 21 May 2009 10:58:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M79ip-0001UE-3N for qemu-devel@nongnu.org; Thu, 21 May 2009 10:58:19 -0400 Received: from [199.232.76.173] (port=48431 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M79io-0001U9-Qr for qemu-devel@nongnu.org; Thu, 21 May 2009 10:58:14 -0400 Received: from mx2.redhat.com ([66.187.237.31]:35442) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M79io-0000Lf-76 for qemu-devel@nongnu.org; Thu, 21 May 2009 10:58:14 -0400 Message-ID: <4A156C02.5050604@redhat.com> Date: Thu, 21 May 2009 17:58:10 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] augment info migrate with page status References: <1242861605-12844-1-git-send-email-glommer@redhat.com> <20090521140504.GA10055@redhat.com> In-Reply-To: <20090521140504.GA10055@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Glauber Costa , aliguori@us.ibm.com, qemu-devel@nongnu.org Daniel P. Berrange wrote: > On Wed, May 20, 2009 at 07:20:05PM -0400, Glauber Costa wrote: > >> This patch augments info migrate output with status about: >> * pages remaining >> * pages transferred >> > > Could you add 'pages total' and/or possibly 'page size', so apps > using this can more easily do calculations, without having to worry > about hardcoding page sizes for each architecture they deal with. > > Oh, what happens if the guest is backed by huge pages ? Does the > 'pages transferred' always count in terms of 4k pages, even if > 2 M & 1 GB pages are in use ? > We should just use bytes. I don't see how backing page size matters. -- error compiling committee.c: too many arguments to function