From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M7BOw-0005RA-Oa for qemu-devel@nongnu.org; Thu, 21 May 2009 12:45:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M7BOq-0005Ch-FY for qemu-devel@nongnu.org; Thu, 21 May 2009 12:45:49 -0400 Received: from [199.232.76.173] (port=47234 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M7BOq-0005CJ-2a for qemu-devel@nongnu.org; Thu, 21 May 2009 12:45:44 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:50790) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M7BOp-0004WL-8z for qemu-devel@nongnu.org; Thu, 21 May 2009 12:45:43 -0400 Message-ID: <4A158530.3030701@web.de> Date: Thu, 21 May 2009 18:45:36 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1242866670-15488-1-git-send-email-glommer@redhat.com> <1242866670-15488-2-git-send-email-glommer@redhat.com> <1242866670-15488-3-git-send-email-glommer@redhat.com> <4A14F35A.6070400@web.de> <20090521114405.GC17959@poweredge.glommer> <4A1580B9.5090907@web.de> <20090521163850.GD24584@poweredge.glommer> In-Reply-To: <20090521163850.GD24584@poweredge.glommer> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig506A1C810FB323CC566286F2" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH STABLE 2/2] net: Fix -net socket parameter checks List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig506A1C810FB323CC566286F2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Glauber Costa wrote: > On Thu, May 21, 2009 at 06:26:33PM +0200, Jan Kiszka wrote: >> Glauber Costa wrote: >>> On Thu, May 21, 2009 at 08:23:22AM +0200, Jan Kiszka wrote: >>>> Glauber Costa wrote: >>>>> My commit ea053add700d8abe203cd79a9ffb082aee4eabc0 broke -net socke= t by >>>>> overwriting an intermediate buffer in the added check_param. Fix th= is >>>>> by switching check_param to automatic buffer allocation and release= , ie. >>>>> callers no longer have to worry about providing a scratch buffer. >>>> That commit was buggy, too, and is awaiting to be fixed in unstable = by >>>> http://permalink.gmane.org/gmane.comp.emulators.qemu/43041. >>>> >>>> But more importantly, it makes no sense in stable because its "heart= ", >>>> param checking for -net is only in unstable (and that's perfectly fi= ne). >>> My interest was in the previous one, since it fixes a bug reported by= a Fedora >>> user. I picked this one, only because it fixes the fix ;-) >>> But I can happily leave it out, if you think it is better. >> This patch 2 has never been a fix of patch 1 in your series. I agree >> that 1/2 is worth considering for stable, but that one never required >> any addon fix. > I got the wrong impression from your changelog then. >=20 > Thanks for taking a look Oh, off-by-one while picking up the hash for this changelog. Should have been 8e4416af458b5fdfc81950005e358de02511eb9f. My bad. Jan --------------enig506A1C810FB323CC566286F2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkoVhTQACgkQniDOoMHTA+lUegCfQPSyvfuczjwKqh+21XU6R2Ec ZYcAnjRJruBQyvaP+Z0ALc2kJ7nc21Z+ =mK9f -----END PGP SIGNATURE----- --------------enig506A1C810FB323CC566286F2--