From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M7DQd-0000lj-Se for qemu-devel@nongnu.org; Thu, 21 May 2009 14:55:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M7DQY-0000dR-Kb for qemu-devel@nongnu.org; Thu, 21 May 2009 14:55:42 -0400 Received: from [199.232.76.173] (port=48021 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M7DQY-0000dI-HY for qemu-devel@nongnu.org; Thu, 21 May 2009 14:55:38 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:41557) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M7DQY-0000Yi-2g for qemu-devel@nongnu.org; Thu, 21 May 2009 14:55:38 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e31.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n4LIpdfQ024954 for ; Thu, 21 May 2009 12:51:39 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4LItV29244040 for ; Thu, 21 May 2009 12:55:31 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4LItUcC018803 for ; Thu, 21 May 2009 12:55:30 -0600 Message-ID: <4A15A39E.4030800@us.ibm.com> Date: Thu, 21 May 2009 13:55:26 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1242930415-20085-1-git-send-email-glommer@redhat.com> In-Reply-To: <1242930415-20085-1-git-send-email-glommer@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] augment info migrate with page status List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: qemu-devel@nongnu.org Glauber Costa wrote: > This patch augments info migrate output with status about: > * ram bytes remaining > * ram bytes transferred > * ram bytes total > > This should be enough for management tools to realize > whether or not there is progress in migration. We can > add more information later on, if the need arrives > > Signed-off-by: Glauber Costa > --- > migration.c | 3 +++ > sysemu.h | 4 ++++ > vl.c | 21 ++++++++++++++++++++- > 3 files changed, 27 insertions(+), 1 deletions(-) > > diff --git a/migration.c b/migration.c > index b9e3368..a771f37 100644 > --- a/migration.c > +++ b/migration.c > @@ -116,6 +116,9 @@ void do_info_migrate(Monitor *mon) > switch (s->get_status(s)) { > case MIG_STATE_ACTIVE: > monitor_printf(mon, "active\n"); > + monitor_printf(mon, "transferred ram: %lu kbytes\n", ram_bytes_transferred() >> 10); > + monitor_printf(mon, "remaining ram: %lu kbytes\n", ram_bytes_remaining() >> 10); > + monitor_printf(mon, "total ram: %lu kbytes\n", ram_bytes_total() >> 10); > ram_addr_t isn't %lu. It's 64-bit. There's a PRI macro somewhere for it... -- Regards, Anthony Liguori