From: Stefan Weil <weil@mail.berlios.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Add new function qemu_register_machines
Date: Thu, 21 May 2009 21:28:24 +0200 [thread overview]
Message-ID: <4A15AB58.1090601@mail.berlios.de> (raw)
In-Reply-To: <4A15A570.4000305@us.ibm.com>
Anthony Liguori schrieb:
> Stefan Weil wrote:
>> Add new function qemu_register_machines.
>>
>> The patch removes the unused prototype register_machines
>> and adds a new function which makes registration of
>> more than one machine a little easier.
>>
>> The new function is applied to the machines in hw/spitz.c
>> (where a static keyword for akitapda_machine was missing),
>> but it can also be applied to several other QEMU source files.
>>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>>
>
> Might as well eliminate qemu_register_machine() and convert everything
> to use qemu_register_machines().
>
Yes. But I prefer to have both interfaces.
qemu_register_machine(&my_machine) looks nicer
than qemu_register_machines(&my_machine, 1).
next prev parent reply other threads:[~2009-05-21 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 18:26 [Qemu-devel] [PATCH] Add new function qemu_register_machines Stefan Weil
2009-05-21 19:03 ` Anthony Liguori
2009-05-21 19:28 ` Stefan Weil [this message]
2009-05-21 20:13 ` [Qemu-devel] " Jan Kiszka
2009-05-21 20:19 ` Stefan Weil
2009-05-21 20:27 ` Jan Kiszka
2009-05-21 20:30 ` Anthony Liguori
2009-05-21 22:33 ` [Qemu-devel] " Paul Brook
2009-05-22 10:08 ` Stefan Weil
2009-05-22 11:59 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A15AB58.1090601@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).