From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M7DwU-0007hH-SQ
	for qemu-devel@nongnu.org; Thu, 21 May 2009 15:28:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M7DwQ-0007b8-Io
	for qemu-devel@nongnu.org; Thu, 21 May 2009 15:28:38 -0400
Received: from [199.232.76.173] (port=38366 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M7DwQ-0007b5-0c
	for qemu-devel@nongnu.org; Thu, 21 May 2009 15:28:34 -0400
Received: from moutng.kundenserver.de ([212.227.126.188]:50096)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1M7DwP-0005oI-Gg
	for qemu-devel@nongnu.org; Thu, 21 May 2009 15:28:33 -0400
Message-ID: <4A15AB58.1090601@mail.berlios.de>
Date: Thu, 21 May 2009 21:28:24 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add new function qemu_register_machines
References: <4A159CBE.9020606@mail.berlios.de> <4A15A570.4000305@us.ibm.com>
In-Reply-To: <4A15A570.4000305@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Anthony Liguori schrieb:
> Stefan Weil wrote:
>> Add new function qemu_register_machines.
>>
>> The patch removes the unused prototype register_machines
>> and adds a new function which makes registration of
>> more than one machine a little easier.
>>
>> The new function is applied to the machines in hw/spitz.c
>> (where a static keyword for akitapda_machine was missing),
>> but it can also be applied to several other QEMU source files.
>>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>>   
>
> Might as well eliminate qemu_register_machine() and convert everything
> to use qemu_register_machines().
>

Yes. But I prefer to have both interfaces.
qemu_register_machine(&my_machine) looks nicer
than qemu_register_machines(&my_machine, 1).