From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M7EeP-0003YL-FL
	for qemu-devel@nongnu.org; Thu, 21 May 2009 16:14:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M7EeK-0003SP-Uj
	for qemu-devel@nongnu.org; Thu, 21 May 2009 16:14:00 -0400
Received: from [199.232.76.173] (port=42793 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M7EeK-0003S6-L7
	for qemu-devel@nongnu.org; Thu, 21 May 2009 16:13:56 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:51608)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1M7EeK-00068l-56
	for qemu-devel@nongnu.org; Thu, 21 May 2009 16:13:56 -0400
Message-ID: <4A15B5F7.4020402@web.de>
Date: Thu, 21 May 2009 22:13:43 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4A159CBE.9020606@mail.berlios.de> <4A15A570.4000305@us.ibm.com>
	<4A15AB58.1090601@mail.berlios.de>
In-Reply-To: <4A15AB58.1090601@mail.berlios.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig8D572F717A903B17B49B9C76"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH] Add new function qemu_register_machines
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig8D572F717A903B17B49B9C76
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Stefan Weil wrote:
> Anthony Liguori schrieb:
>> Stefan Weil wrote:
>>> Add new function qemu_register_machines.
>>>
>>> The patch removes the unused prototype register_machines
>>> and adds a new function which makes registration of
>>> more than one machine a little easier.
>>>
>>> The new function is applied to the machines in hw/spitz.c
>>> (where a static keyword for akitapda_machine was missing),
>>> but it can also be applied to several other QEMU source files.
>>>
>>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>>>  =20
>> Might as well eliminate qemu_register_machine() and convert everything=

>> to use qemu_register_machines().
>>
>=20
> Yes. But I prefer to have both interfaces.
> qemu_register_machine(&my_machine) looks nicer
> than qemu_register_machines(&my_machine, 1).
>=20

static inline void qemu_register_machine(QEMUMachine *m)
{
    qemu_register_machines(m, 1);
}

BTW, this is also a good chance to drop the now unused return value.

Jan


--------------enig8D572F717A903B17B49B9C76
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkoVtgAACgkQniDOoMHTA+noEQCfVrP78D43OBnAAN9iPBA+Yc7V
plgAnjqGWfwymXikBx/oGNeOCvsGhJ3m
=tMwt
-----END PGP SIGNATURE-----

--------------enig8D572F717A903B17B49B9C76--