From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M7Jf0-0005pW-GS for qemu-devel@nongnu.org; Thu, 21 May 2009 21:34:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M7Jeu-0005ma-Tc for qemu-devel@nongnu.org; Thu, 21 May 2009 21:34:57 -0400 Received: from [199.232.76.173] (port=44020 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M7Jeu-0005mU-Qg for qemu-devel@nongnu.org; Thu, 21 May 2009 21:34:52 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:52871) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M7Jeu-0001JD-0t for qemu-devel@nongnu.org; Thu, 21 May 2009 21:34:52 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n4M1URsl029959 for ; Thu, 21 May 2009 21:30:27 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4M1YoQR246792 for ; Thu, 21 May 2009 21:34:50 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4M1YosF017126 for ; Thu, 21 May 2009 21:34:50 -0400 Message-ID: <4A160138.7050109@us.ibm.com> Date: Thu, 21 May 2009 20:34:48 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT f80f9ec] Convert machine registration to use module initfunctions References: <200905211348.n4LDmnYd025976@d01av04.pok.ibm.com> <200905212336.02493.paul@codesourcery.com> <20090521225039.GA26811@poweredge.glommer> In-Reply-To: <20090521225039.GA26811@poweredge.glommer> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: Paul Brook , qemu-devel@nongnu.org Glauber Costa wrote: > On Thu, May 21, 2009 at 11:36:01PM +0100, Paul Brook wrote: > >>> From: Anthony Liguori >>> >>> This cleans up quite a lot of #ifdefs, extern variables, and other >>> ugliness. >>> >> This changes the default for at least the ARM target, which I consider to be a >> bug. Worse than that, the default is now arbitrary and depends on unspecified >> toolchain implementation details. >> > How about we start sending patches to the list? Then this kind of thing can be avoided. > It doesn't magically solve the problem. I post most patches and still regressions slip in. I review every patch I commit and still regressions slip in. People are imperfect. The best way to prevent regressions is to have an automated test suite that everyone can use to validate that a series of patches doesn't break things. > Note that although at first there is nothing wrong with just messing around with > the devel repository, this kind of thing breaks bisectability of the tree, which is kind > of a pain. > You can always --skip. I understand your point. In this case, the patch was very large and mostly mechanical. There was a design flaw but I didn't expect to get much useful feedback because of the shear amount of things it touched. Regression tests are the only way we're going to really solve this problem. -- Regards, Anthony Liguori