Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT f80f9ec] Convert machine registration to use module initfunctions

[Anthony Liguori <aliguori@us.ibm.com>]

Glauber Costa wrote:
>>> Note that although at first there is nothing wrong with just messing around with
>>> the devel repository, this kind of thing breaks bisectability of the 
>>> tree, which is kind of a pain.
>>>   
>>>       
>> You can always --skip.  I understand your point.  In this case, the  
>> patch was very large and mostly mechanical.  There was a design flaw but  
>> I didn't expect to get much useful feedback because of the shear amount  
>> of things it touched.
>>     
>
> however, for a lot of patches that recently went in, there were discussions
> _after_ the patch made its way to the repository. The discussions help, everybody
> does that. Giving people a chance to stand up and raise valid points before
> a change is made to the repository is at the very least, a polite attitude to be
> taken. And although I agree with you that it does not solve all problems, it
> really does help improving the situation by a huge leap.
>   

I appreciate where you're coming from.  I've made the same argument in 
the context of other projects.

Practically speaking, very few projects have every single patch go to 
the mailing list first.  Almost always, quick fixes or trivial things 
are committed directly by the maintainers.  I think the real balancing 
act is determine what falls into the category of quick fixes/trivial 
changes and what ought to go to the list.

So please do provide feedback on particular commits that you think 
should have gone to the mailing list.  I don't think there will every be 
an every single change to the mailing list first policy, but it's 
certainly open to discussion about what changes should get review first.

-- 
Regards,

Anthony Liguori