From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M7K4E-0000mf-0G for qemu-devel@nongnu.org; Thu, 21 May 2009 22:01:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M7K49-0000mO-F0 for qemu-devel@nongnu.org; Thu, 21 May 2009 22:01:01 -0400 Received: from [199.232.76.173] (port=54408 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M7K49-0000mL-CA for qemu-devel@nongnu.org; Thu, 21 May 2009 22:00:57 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:57607) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M7K48-0003bm-Uk for qemu-devel@nongnu.org; Thu, 21 May 2009 22:00:57 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n4M1uWOF012290 for ; Thu, 21 May 2009 21:56:32 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4M20tVh154892 for ; Thu, 21 May 2009 22:00:55 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4M20tOK011423 for ; Thu, 21 May 2009 22:00:55 -0400 Message-ID: <4A160755.9090700@us.ibm.com> Date: Thu, 21 May 2009 21:00:53 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT f80f9ec] Convert machine registration to use module initfunctions References: <200905211348.n4LDmnYd025976@d01av04.pok.ibm.com> <200905212336.02493.paul@codesourcery.com> <20090521225039.GA26811@poweredge.glommer> <4A160138.7050109@us.ibm.com> <20090522014957.GG24584@poweredge.glommer> In-Reply-To: <20090522014957.GG24584@poweredge.glommer> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: Paul Brook , qemu-devel@nongnu.org Glauber Costa wrote: >>> Note that although at first there is nothing wrong with just messing around with >>> the devel repository, this kind of thing breaks bisectability of the >>> tree, which is kind of a pain. >>> >>> >> You can always --skip. I understand your point. In this case, the >> patch was very large and mostly mechanical. There was a design flaw but >> I didn't expect to get much useful feedback because of the shear amount >> of things it touched. >> > > however, for a lot of patches that recently went in, there were discussions > _after_ the patch made its way to the repository. The discussions help, everybody > does that. Giving people a chance to stand up and raise valid points before > a change is made to the repository is at the very least, a polite attitude to be > taken. And although I agree with you that it does not solve all problems, it > really does help improving the situation by a huge leap. > I appreciate where you're coming from. I've made the same argument in the context of other projects. Practically speaking, very few projects have every single patch go to the mailing list first. Almost always, quick fixes or trivial things are committed directly by the maintainers. I think the real balancing act is determine what falls into the category of quick fixes/trivial changes and what ought to go to the list. So please do provide feedback on particular commits that you think should have gone to the mailing list. I don't think there will every be an every single change to the mailing list first policy, but it's certainly open to discussion about what changes should get review first. -- Regards, Anthony Liguori