Re: [Qemu-devel] [PATCH] Add new function qemu_register_machines

[Stefan Weil <weil@mail.berlios.de>]

Paul Brook schrieb:
> On Thursday 21 May 2009, Stefan Weil wrote:
>> Add new function qemu_register_machines.
>>
>> The patch removes the unused prototype register_machines
>> and adds a new function which makes registration of
>> more than one machine a little easier.
>
> I don't see this as an improvement.
>
> Paul

Hi Paul,

well, it's a matter of personal taste whether you prefer
to have one or two interfaces for machine registration.

The new function is an improvement if you want to reduce
lines of code and binary code size.

Removing unused entries like register_machines from
header files is also an improvement. This part of
my patch is fixed now in QEMU HEAD, thanks Anthony!

And adding "static" to a machine declaration which is
only used locally is also an improvement (hw/spitz.c).

I assume that you agree that those last two points are
an improvement.

So the patch improves two details and adds something
where people disagree about its usefulness.

What now? Will the patch be rejected because you
don't see an improvement? Will you fix the missing
"static" yourself? Do you want a new patch without
qemu_register_machines? Or a new patch which uses
qemu_register_machines for all files with more than
one machine?

Your short feedback is not really helpful because there
remain too many questions.

Stefan