From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M7Wyw-0005nH-Jf for qemu-devel@nongnu.org; Fri, 22 May 2009 11:48:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M7Wyr-0005lB-Pg for qemu-devel@nongnu.org; Fri, 22 May 2009 11:48:26 -0400 Received: from [199.232.76.173] (port=52578 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M7Wyr-0005l4-GH for qemu-devel@nongnu.org; Fri, 22 May 2009 11:48:21 -0400 Received: from an-out-0708.google.com ([209.85.132.247]:55003) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M7Wyr-00086c-4B for qemu-devel@nongnu.org; Fri, 22 May 2009 11:48:21 -0400 Received: by an-out-0708.google.com with SMTP id d11so1037710and.37 for ; Fri, 22 May 2009 08:48:19 -0700 (PDT) Message-ID: <4A16C941.3070900@codemonkey.ws> Date: Fri, 22 May 2009 10:48:17 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Windows runtime error References: <200905221304.53279.paul@codesourcery.com> <4A16A38A.40800@codemonkey.ws> <200905221415.40621.paul@codesourcery.com> In-Reply-To: <200905221415.40621.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Blue Swirl , Consul , qemu-devel@nongnu.org Paul Brook wrote: > On Friday 22 May 2009, Anthony Liguori wrote: > >> Paul Brook wrote: >> >>>>> Don't use whole-archive for hwlib or libqemu objects >>>>> >>>>> Signed-off-by: Blue Swirl >>>>> >>>> hwlib definitely needs whole-archive. >>>> >>>> Why did this break arm-softmmu? It builds fine for me. >>>> >>> In function `fdctrl_stop_transfer': >>> fdc.c:1086: undefined reference to `DMA_release_DREQ' >>> >>> There appears to be a missing dependency somewhere, I suspect libhw*.a >>> doesn't get rebuilt when you move objects from Makefile.target to >>> Makefile.hw. >>> >> So a fresh rebuild "fixes" the problem? >> > > No, sorry, I mean occasionally you end up with a stale libhw.a. > > >> Blue, can you revert this commit then? >> > > Both this (whole-archive) and the preceding fdc change need to be reverted. > I've reverted the whole-archive change and the fdc. I've left scsi intact. They were blocking my testing of other patches. Everything now links and seems to work. Regards, Anthony Liguori