From: Anthony Liguori <anthony@codemonkey.ws>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Consul <void@aleksoft.net>, Paul Brook <paul@codesourcery.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Windows runtime error
Date: Fri, 22 May 2009 11:39:28 -0500 [thread overview]
Message-ID: <4A16D540.60208@codemonkey.ws> (raw)
In-Reply-To: <f43fc5580905220912q49611286y46b74b6455160f1c@mail.gmail.com>
Blue Swirl wrote:
> Good for you. Should I then revert the qdev commit that broke pcnet
> (9d07d7579bcaf01e05c511c63d091ed2ac310091), because now Sparc crashes
> immediately when network is used?
>
qdev should have gotten more testing before being committed. I won't
disagree with you there.
Your changes didn't introduce new functionality. The risk of reverting
it was very low. I also did give you a chance to fix it first, I have
no way of knowing how long that was going to take you. It completely
broke target-i386 so its a major blocker. Paul also agreed that it
should be reverted.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-05-22 16:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 21:58 [Qemu-devel] Windows runtime error Consul
2009-05-22 2:11 ` Anthony Liguori
2009-05-22 12:04 ` Paul Brook
2009-05-22 13:07 ` Anthony Liguori
2009-05-22 13:15 ` Paul Brook
2009-05-22 15:48 ` Anthony Liguori
2009-05-22 16:12 ` Blue Swirl
2009-05-22 16:39 ` Anthony Liguori [this message]
2009-05-22 15:55 ` Blue Swirl
2009-05-22 16:36 ` Anthony Liguori
2009-05-24 9:14 ` Avi Kivity
2009-05-27 22:39 ` Anthony Liguori
2009-05-22 15:51 ` Blue Swirl
2009-05-22 16:35 ` Anthony Liguori
2009-05-22 16:53 ` Blue Swirl
2009-05-22 17:15 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A16D540.60208@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=void@aleksoft.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).