From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M7XmV-0004z9-A6
	for qemu-devel@nongnu.org; Fri, 22 May 2009 12:39:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M7XmQ-0004y9-WD
	for qemu-devel@nongnu.org; Fri, 22 May 2009 12:39:38 -0400
Received: from [199.232.76.173] (port=51912 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M7XmQ-0004y6-QF
	for qemu-devel@nongnu.org; Fri, 22 May 2009 12:39:34 -0400
Received: from rv-out-0708.google.com ([209.85.198.240]:22282)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1M7XmQ-0006sN-EI
	for qemu-devel@nongnu.org; Fri, 22 May 2009 12:39:34 -0400
Received: by rv-out-0708.google.com with SMTP id c5so678306rvf.22
	for <qemu-devel@nongnu.org>; Fri, 22 May 2009 09:39:33 -0700 (PDT)
Message-ID: <4A16D540.60208@codemonkey.ws>
Date: Fri, 22 May 2009 11:39:28 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Windows runtime error
References: <gv4ipi$ani$1@ger.gmane.org>	
	<200905221304.53279.paul@codesourcery.com>	
	<4A16A38A.40800@codemonkey.ws>	
	<200905221415.40621.paul@codesourcery.com>	
	<4A16C941.3070900@codemonkey.ws>
	<f43fc5580905220912q49611286y46b74b6455160f1c@mail.gmail.com>
In-Reply-To: <f43fc5580905220912q49611286y46b74b6455160f1c@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Consul <void@aleksoft.net>, Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org

Blue Swirl wrote:
> Good for you. Should I then revert the qdev commit that broke pcnet
> (9d07d7579bcaf01e05c511c63d091ed2ac310091), because now Sparc crashes
> immediately when network is used?
>   
qdev should have gotten more testing before being committed.  I won't 
disagree with you there.

Your changes didn't introduce new functionality.  The risk of reverting 
it was very low.  I also did give you a chance to fix it first, I have 
no way of knowing how long that was going to take you.  It completely 
broke target-i386 so its a major blocker.  Paul also agreed that it 
should be reverted.

Regards,

Anthony Liguori