From: Jan Kiszka <jan.kiszka@web.de>
To: Glauber Costa <glommer@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] kvm: Mark full address range dirty on live migration start
Date: Sat, 23 May 2009 15:47:03 +0200 [thread overview]
Message-ID: <4A17FE57.3070207@web.de> (raw)
In-Reply-To: <20090523134716.GB26811@poweredge.glommer>
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
Glauber Costa wrote:
> On Fri, May 22, 2009 at 11:51:45PM +0200, Jan Kiszka wrote:
>> As Avi correctly noted, last_ram_offset does not mark the last physical
>> RAM address the guest may see (due to non-continuous memory regions).
>> Ensure that we catch them all by marking the full possible address range
>> dirty.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Indeed, we already do something in that lines in qemu-kvm tree,
> in a place that does not apply for It makes a lot of sense. Just
> maybe you could just -1UL instead of defining a new constant, but I don't
> really care.
I intentionally made this verbose.
>
> As soon as this is applied to master, I'll pick it for stable too.
Migration for KVM would be a new feature for stable. It requires a new
CPU save/restore format (V9). Do think that qualifies it for stable.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2009-05-23 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 21:51 [Qemu-devel] [PATCH] kvm: Mark full address range dirty on live migration start Jan Kiszka
2009-05-23 13:47 ` Glauber Costa
2009-05-23 13:47 ` Jan Kiszka [this message]
2009-05-24 18:23 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A17FE57.3070207@web.de \
--to=jan.kiszka@web.de \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).