From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M7rZA-0003JK-UV for qemu-devel@nongnu.org; Sat, 23 May 2009 09:47:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M7rZ6-0003Hs-20 for qemu-devel@nongnu.org; Sat, 23 May 2009 09:47:12 -0400 Received: from [199.232.76.173] (port=55685 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M7rZ5-0003Hp-RU for qemu-devel@nongnu.org; Sat, 23 May 2009 09:47:07 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:44978) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M7rZ5-0001ZC-7K for qemu-devel@nongnu.org; Sat, 23 May 2009 09:47:07 -0400 Message-ID: <4A17FE57.3070207@web.de> Date: Sat, 23 May 2009 15:47:03 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] kvm: Mark full address range dirty on live migration start References: <4A171E71.1000701@web.de> <20090523134716.GB26811@poweredge.glommer> In-Reply-To: <20090523134716.GB26811@poweredge.glommer> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigE39D37BF2599F6E4F6F1E5FB" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE39D37BF2599F6E4F6F1E5FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Glauber Costa wrote: > On Fri, May 22, 2009 at 11:51:45PM +0200, Jan Kiszka wrote: >> As Avi correctly noted, last_ram_offset does not mark the last physica= l >> RAM address the guest may see (due to non-continuous memory regions). >> Ensure that we catch them all by marking the full possible address ran= ge >> dirty. >> >> Signed-off-by: Jan Kiszka > Indeed, we already do something in that lines in qemu-kvm tree,=20 > in a place that does not apply for It makes a lot of sense. Just > maybe you could just -1UL instead of defining a new constant, but I don= 't > really care. I intentionally made this verbose. >=20 > As soon as this is applied to master, I'll pick it for stable too. Migration for KVM would be a new feature for stable. It requires a new CPU save/restore format (V9). Do think that qualifies it for stable. Jan --------------enigE39D37BF2599F6E4F6F1E5FB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkoX/lcACgkQniDOoMHTA+neLQCdE7isBtFUSjDT8/EEm40kX1N9 WaUAn025VFlL+XpyZTc9Jc5bZ22J3Har =fU/A -----END PGP SIGNATURE----- --------------enigE39D37BF2599F6E4F6F1E5FB--