From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Glauber Costa <glommer@redhat.com>,
aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] add non-arbitrary migration stop condition
Date: Sun, 24 May 2009 11:29:12 +0300 [thread overview]
Message-ID: <4A190558.7030400@redhat.com> (raw)
In-Reply-To: <4A16091E.9040506@codemonkey.ws>
Anthony Liguori wrote:
> Glauber Costa wrote:
>>
>> Signed-off-by: Glauber Costa <glommer@redhat.com>
>> ---
>> migration.c | 7 +++++++
>> migration.h | 2 ++
>> vl.c | 14 ++++++++++++--
>> 3 files changed, 21 insertions(+), 2 deletions(-)
>>
>> diff --git a/migration.c b/migration.c
>> index 401383c..4036e64 100644
>> --- a/migration.c
>> +++ b/migration.c
>> @@ -107,6 +107,13 @@ void do_migrate_set_speed(Monitor *mon, const
>> char *value)
>> }
>>
>> +static int64_t max_downtime = 30000000;
>>
>
> In units of..? Wouldn't it make sense to store this in milliseconds
> or microseconds as opposed to nanoseconds?
qemu time is in nanoseconds, IIRC. User visible quantities should be in
seconds.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-05-24 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 22:49 [Qemu-devel] [PATCH 0/2] Transfer of funds Glauber Costa
2009-05-21 22:49 ` [Qemu-devel] [PATCH 1/2] add non-arbitrary migration stop condition Glauber Costa
2009-05-21 22:49 ` [Qemu-devel] [PATCH 2/2] set migration max downtime Glauber Costa
2009-05-22 2:09 ` Anthony Liguori
2009-05-24 11:07 ` Avi Kivity
2009-05-24 19:47 ` Anthony Liguori
2009-05-24 19:52 ` Avi Kivity
2009-05-24 22:40 ` M. Warner Losh
2009-05-22 2:08 ` [Qemu-devel] [PATCH 1/2] add non-arbitrary migration stop condition Anthony Liguori
2009-05-24 8:29 ` Avi Kivity [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-05-28 19:22 [Qemu-devel] [PATCH 0/2] Add non-arbitrary treshold for migration Glauber Costa
2009-05-28 19:22 ` [Qemu-devel] [PATCH 1/2] add non-arbitrary migration stop condition Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A190558.7030400@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).