From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M8DW2-0005yR-OL for qemu-devel@nongnu.org; Sun, 24 May 2009 09:13:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M8DVx-0005uj-UU for qemu-devel@nongnu.org; Sun, 24 May 2009 09:13:26 -0400 Received: from [199.232.76.173] (port=33968 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M8DE7-00068C-TU for qemu-devel@nongnu.org; Sun, 24 May 2009 08:54:56 -0400 Received: from mx2.redhat.com ([66.187.237.31]:33867) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M8955-0008Un-7W for qemu-devel@nongnu.org; Sun, 24 May 2009 04:29:19 -0400 Message-ID: <4A190558.7030400@redhat.com> Date: Sun, 24 May 2009 11:29:12 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/2] add non-arbitrary migration stop condition References: <1242946174-30451-1-git-send-email-glommer@redhat.com> <1242946174-30451-2-git-send-email-glommer@redhat.com> <4A16091E.9040506@codemonkey.ws> In-Reply-To: <4A16091E.9040506@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Glauber Costa , aliguori@us.ibm.com, qemu-devel@nongnu.org Anthony Liguori wrote: > Glauber Costa wrote: >> >> Signed-off-by: Glauber Costa >> --- >> migration.c | 7 +++++++ >> migration.h | 2 ++ >> vl.c | 14 ++++++++++++-- >> 3 files changed, 21 insertions(+), 2 deletions(-) >> >> diff --git a/migration.c b/migration.c >> index 401383c..4036e64 100644 >> --- a/migration.c >> +++ b/migration.c >> @@ -107,6 +107,13 @@ void do_migrate_set_speed(Monitor *mon, const >> char *value) >> } >> >> +static int64_t max_downtime = 30000000; >> > > In units of..? Wouldn't it make sense to store this in milliseconds > or microseconds as opposed to nanoseconds? qemu time is in nanoseconds, IIRC. User visible quantities should be in seconds. -- error compiling committee.c: too many arguments to function