From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M8DL7-0008LO-RY
	for qemu-devel@nongnu.org; Sun, 24 May 2009 09:02:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M8DL3-0008Ja-A7
	for qemu-devel@nongnu.org; Sun, 24 May 2009 09:02:09 -0400
Received: from [199.232.76.173] (port=33940 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M8DDs-0005uN-7u
	for qemu-devel@nongnu.org; Sun, 24 May 2009 08:54:40 -0400
Received: from mx2.redhat.com ([66.187.237.31]:43763)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1M89kN-0005o7-9y
	for qemu-devel@nongnu.org; Sun, 24 May 2009 05:11:59 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4O9BwHP005144
	for <qemu-devel@nongnu.org>; Sun, 24 May 2009 05:11:58 -0400
Message-ID: <4A190F5B.8050309@redhat.com>
Date: Sun, 24 May 2009 12:11:55 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Change virtio-console to
	PCI_CLASS_SERIAL_OTHER
References: <1243012478.29542.18.camel@blaa>
In-Reply-To: <1243012478.29542.18.camel@blaa>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: ajax@redhat.com, qemu-devel <qemu-devel@nongnu.org>

Mark McLoughlin wrote:
> From: Adam Jackson <ajax@redhat.com>
>
> We're using PCI_CLASS_DISPLAY_OTHER now, but qemu-kvm.git is using
> PCI_CLASS_OTHERS because:
>
>   "As a PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on
>    Windows XP (possibly Windows disables acceleration since it fails
>    to find a driver)."
>   

That's really unnecessary now, since virtio-console is not enabled by 
default.

> While this is valid, many versions of X will get confused by it.
> Class major number of 0 gets treated as a possibly prehistoric VGA
> device, and then the autoconfig logic gets confused trying to figure
> out whether the virtio console or the pv vga device are the real VGA.
>
> We should really set a proper class ID. 0x0780 (serial / other) seems
> most appropriate. This shouldn't require any kernel changes, the
> modalias for virtio looks like:
>   

Yes, serial is a much better fit.

-- 
error compiling committee.c: too many arguments to function