From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M8DYD-0007NB-7u
	for qemu-devel@nongnu.org; Sun, 24 May 2009 09:15:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M8DY8-0007KS-6l
	for qemu-devel@nongnu.org; Sun, 24 May 2009 09:15:40 -0400
Received: from [199.232.76.173] (port=33933 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M8DDD-0005fh-Gf
	for qemu-devel@nongnu.org; Sun, 24 May 2009 08:53:59 -0400
Received: from mx2.redhat.com ([66.187.237.31]:41548)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1M8BUg-0005Wl-Ti
	for qemu-devel@nongnu.org; Sun, 24 May 2009 07:03:55 -0400
Message-ID: <4A192997.6090405@redhat.com>
Date: Sun, 24 May 2009 14:03:51 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] run vnc without sdl
References: <1242930079-19798-1-git-send-email-glommer@redhat.com>
	<4A15CE70.7030201@us.ibm.com>
In-Reply-To: <4A15CE70.7030201@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org

Anthony Liguori wrote:
> Glauber Costa wrote:
>> commit f92f8afebe038a4eae9ad90a140c9529f94919a6
>> "Eliminate --disable-gfx-check and make VNC default when SDL not 
>> available"
>> broke usage of vnc. Passing -vnc <something> now fails because it 
>> cannot initialize
>> SDL.
>>
>> Signed-off-by: Glauber Costa <glommer@redhat.com>
>>   
>
> What do you think about the attached?  My goal with the original 
> refactoring was to more cleanly separate things that's why I didn't 
> want to introduce the !vnc_display.
>
> Ideally, we could make the various display states register themselves 
> and completely eliminate the #ifdefs...
>

IMO we should not mix bug fixes with refactoring.  Ideally Glauber's fix 
should have been committed followed by this patch.  If the refactoring 
introduces a new regression, we can then safely revert it.

-- 
error compiling committee.c: too many arguments to function