From: Avi Kivity <avi@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fully split aio_pool from BlockDriver
Date: Mon, 25 May 2009 13:58:10 +0300 [thread overview]
Message-ID: <4A1A79C2.5020904@redhat.com> (raw)
In-Reply-To: <20090525103732.GA11391@lst.de>
Christoph Hellwig wrote:
> Now that we have a separate aio pool structure we can remove those
> aio pool details from BlockDriver.
>
> Every driver supporting AIO now needs to declare a static AIOPool
> with the aiocb size and the cancellation method. This cleans up the
> current code considerably and will make it cleaner and more obvious
> to support two different aio implementations behind a single
> BlockDriver.
>
Looks good.
>
> +static void curl_aio_cancel(BlockDriverAIOCB *blockacb)
> +{
> + // Do we have to implement canceling? Seems to work without...
> +}
> +
>
We do, but I'd rather not think exactly what to do here. I'd like aio
cancellation to be asynchronous so things like controller resets don't
stall the vcpu.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-05-25 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 10:37 [Qemu-devel] [PATCH] fully split aio_pool from BlockDriver Christoph Hellwig
2009-05-25 10:58 ` Avi Kivity [this message]
2009-05-25 13:45 ` [Qemu-devel] [PATCH] qcow: add qcow_aio_setup helper Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1A79C2.5020904@redhat.com \
--to=avi@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).