From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M8Xst-0004Yh-96 for qemu-devel@nongnu.org; Mon, 25 May 2009 06:58:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M8Xso-0004YV-K6 for qemu-devel@nongnu.org; Mon, 25 May 2009 06:58:22 -0400 Received: from [199.232.76.173] (port=45314 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M8Xso-0004YS-GS for qemu-devel@nongnu.org; Mon, 25 May 2009 06:58:18 -0400 Received: from mx2.redhat.com ([66.187.237.31]:35630) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M8Xso-0008NQ-0W for qemu-devel@nongnu.org; Mon, 25 May 2009 06:58:18 -0400 Message-ID: <4A1A79C2.5020904@redhat.com> Date: Mon, 25 May 2009 13:58:10 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] fully split aio_pool from BlockDriver References: <20090525103732.GA11391@lst.de> In-Reply-To: <20090525103732.GA11391@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Christoph Hellwig wrote: > Now that we have a separate aio pool structure we can remove those > aio pool details from BlockDriver. > > Every driver supporting AIO now needs to declare a static AIOPool > with the aiocb size and the cancellation method. This cleans up the > current code considerably and will make it cleaner and more obvious > to support two different aio implementations behind a single > BlockDriver. > Looks good. > > +static void curl_aio_cancel(BlockDriverAIOCB *blockacb) > +{ > + // Do we have to implement canceling? Seems to work without... > +} > + > We do, but I'd rather not think exactly what to do here. I'd like aio cancellation to be asynchronous so things like controller resets don't stall the vcpu. -- error compiling committee.c: too many arguments to function