From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M8rYF-0004kr-JU for qemu-devel@nongnu.org; Tue, 26 May 2009 03:58:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M8rYB-0004jA-09 for qemu-devel@nongnu.org; Tue, 26 May 2009 03:58:23 -0400 Received: from [199.232.76.173] (port=55424 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M8rYA-0004j4-Kl for qemu-devel@nongnu.org; Tue, 26 May 2009 03:58:18 -0400 Received: from mx20.gnu.org ([199.232.41.8]:63749) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M8rYA-00062C-6D for qemu-devel@nongnu.org; Tue, 26 May 2009 03:58:18 -0400 Received: from mail-ew0-f213.google.com ([209.85.219.213]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M8rY8-0008JC-Eg for qemu-devel@nongnu.org; Tue, 26 May 2009 03:58:16 -0400 Received: by ewy9 with SMTP id 9so3287465ewy.34 for ; Tue, 26 May 2009 00:58:14 -0700 (PDT) Message-ID: <4A1BA111.9060801@codemonkey.ws> Date: Tue, 26 May 2009 02:58:09 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Do we need CONFIG_AIO? References: <20090525082151.GA4107@lst.de> <4A1A85B4.3060200@eu.citrix.com> In-Reply-To: <4A1A85B4.3060200@eu.citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: Christoph Hellwig , "qemu-devel@nongnu.org" Stefano Stabellini wrote: > Christoph Hellwig wrote: > > >> Currently all aio code in the raw-posix block driver depends on a >> CONFIG_AIO symbol that gets set based on the availability of the >> pthreads library. Beeing able to rely on unconditional aio support >> means we could remove the whole code for plain bdrv_read/bdrv_write >> in raw-posix.c which is about 300 lines of code and a duplicated code >> path. Is there any Posix-ish platform qemu supports that does not >> have pthreads support? >> >> > > MiniOS. > I would appreciate if you keep that flag. > Threads are not going to be able to remain an optional dependency forever. I would be willing to merge something to remove CONFIG_AIO although I expect that there will be some fall out. Some people are using --disable-aio today for either historic reasons or because there are weird bugs with AIO enabled. Regards, Anthony Liguori