From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M8rjS-0001hw-Fv
	for qemu-devel@nongnu.org; Tue, 26 May 2009 04:09:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M8rjN-0001YB-N0
	for qemu-devel@nongnu.org; Tue, 26 May 2009 04:09:57 -0400
Received: from [199.232.76.173] (port=58688 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M8rjN-0001Y1-HF
	for qemu-devel@nongnu.org; Tue, 26 May 2009 04:09:53 -0400
Received: from mx2.redhat.com ([66.187.237.31]:41083)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1M8rjN-00074t-2Q
	for qemu-devel@nongnu.org; Tue, 26 May 2009 04:09:53 -0400
Message-ID: <4A1BA345.3040104@redhat.com>
Date: Tue, 26 May 2009 11:07:33 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 04/11] qemu: helper routines for pci	access.
References: <cover.1243253205.git.mst@redhat.com>
	<20090525122533.GE5046@redhat.com>
	<20090526023337.GF13076%yamahata@valinux.co.jp>
	<20090526064152.GH6856@redhat.com>
In-Reply-To: <20090526064152.GH6856@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org, Christian Borntraeger <borntraeger@de.ibm.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Blue Swirl <blauwirbel@gmail.com>, Isaku Yamahata <yamahata@valinux.co.jp>, Paul Brook <paul@codesourcery.com>

Michael S. Tsirkin wrote:
> On Tue, May 26, 2009 at 11:33:37AM +0900, Isaku Yamahata wrote:
>   
>> On Mon, May 25, 2009 at 03:25:33PM +0300, Michael S. Tsirkin wrote:
>>     
>>> Add inline routines for convenient access to pci devices
>>> with correct (little) endianness. Will be used by MSI-X support.
>>>       
>> Just a minor comment.
>> How about to add pci_[sg]et_byte() for consistency?
>>     
>
> I don't see that it makes sense - pci_set_long(config, value)
> is shorter than *((uint32_t *)config) = cpu_to_le32(value),
> but single bytes don't have endianness, and *config = value
> is shorter.
>   

It's nice to have consistent APIs though.

-- 
error compiling committee.c: too many arguments to function