From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M8rkW-00050G-5v for qemu-devel@nongnu.org; Tue, 26 May 2009 04:11:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M8rkR-0004to-M3 for qemu-devel@nongnu.org; Tue, 26 May 2009 04:11:03 -0400 Received: from [199.232.76.173] (port=55143 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M8rkR-0004tV-GP for qemu-devel@nongnu.org; Tue, 26 May 2009 04:10:59 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:34866) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M8rkR-0007D2-3t for qemu-devel@nongnu.org; Tue, 26 May 2009 04:10:59 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e32.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n4Q87Mik032102 for ; Tue, 26 May 2009 02:07:22 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4Q8ArHn232430 for ; Tue, 26 May 2009 02:10:53 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4Q8Aq8f006548 for ; Tue, 26 May 2009 02:10:53 -0600 Message-ID: <4A1BA408.5030400@us.ibm.com> Date: Tue, 26 May 2009 03:10:48 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: autotest (was Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT f80f9ec] Convert machine registration to use module initfunctions) References: <200905211348.n4LDmnYd025976@d01av04.pok.ibm.com> <200905212336.02493.paul@codesourcery.com> <20090521225039.GA26811@poweredge.glommer> <4A160138.7050109@us.ibm.com> <4A18068F.5020700@redhat.com> <4A19A422.80807@us.ibm.com> <4A19B32E.2020201@redhat.com> In-Reply-To: <4A19B32E.2020201@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Glauber Costa , dlaor@redhat.com, Paul Brook , qemu-devel@nongnu.org Avi Kivity wrote: > Anthony Liguori wrote: >> Autotest doesn't currently test the regressions that I want to test. > > Which regressions do you want to test? For instance, we often have networking regressions. In particular, with the refactoring going on in slirp and tun/tap, I'd really like to have an automated way to test slirp and tap with TCP transmit/receive, and slirp redir. I have something locally to do this that I intend on posting in the next few days. > > One way to increase coverage is to require each patch (fix or feature) > to come with a test. On the other hand, it might stop contributions > instead of increasing test coverage. > > I've used this method for the x86 emulator in kvm, with some success. I wouldn't require kvm-autotest, but I'd like to have an interest set of unit tests that are then usable within kvm-autotest. Once we have that, asking politely for tests to be written I think is quite reasonable. Regards, Anthony Liguori