From: john cooper <john.cooper@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: john.cooper@redhat.com, qemu-devel@nongnu.org,
KVM list <kvm@vger.kernel.org>
Subject: [Qemu-devel] Re: [PATCH 0/2] Add serial number support for virtio_blk, V2
Date: Tue, 26 May 2009 20:26:17 -0400 [thread overview]
Message-ID: <4A1C88A9.5080206@redhat.com> (raw)
In-Reply-To: <20090520073129.GA17378@infradead.org>
Christoph Hellwig wrote:
> On Mon, May 18, 2009 at 11:00:41AM -0400, john cooper wrote:
>> Christoph Hellwig wrote:
>>> So why can't we re-use the existing interfaces instead of inventing a
>>> new one?
>> I'm unclear to what specifically you're referring -- the
>> ioctl() used to retrieve the serial number in the guest?
>
> Well, there's not specific ioctl to get a serial number for scsi, but
> given that we now have SG_IO passthrough in virtio-blk it should be easy
> enough to provide inquiry data and the device identification VPD page
> by that way. Not sure how it's handled for ide, maybe that way
> is even easier.
Yea, I'm hardly in enamored with the IDE/ATA
diatribe. But in this case displacing the new
ioctl with HDIO_GET_IDENTITY seemed the most
straightforward means to provide access within
an existing interface. Updated patch follows.
-john
--
john.cooper@redhat.com
prev parent reply other threads:[~2009-05-27 0:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 17:06 [Qemu-devel] [PATCH 0/2] Add serial number support for virtio_blk, V2 john cooper
2009-05-18 12:13 ` [Qemu-devel] " Christoph Hellwig
2009-05-18 15:00 ` john cooper
2009-05-20 7:31 ` Christoph Hellwig
2009-05-20 7:36 ` Gleb Natapov
2009-05-27 0:26 ` john cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1C88A9.5080206@redhat.com \
--to=john.cooper@redhat.com \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).