From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M970W-0004az-NB for qemu-devel@nongnu.org; Tue, 26 May 2009 20:28:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M970R-0004an-Vs for qemu-devel@nongnu.org; Tue, 26 May 2009 20:28:35 -0400 Received: from [199.232.76.173] (port=43016 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M970R-0004ak-PN for qemu-devel@nongnu.org; Tue, 26 May 2009 20:28:31 -0400 Received: from mx2.redhat.com ([66.187.237.31]:58303) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M970R-0006Ag-8E for qemu-devel@nongnu.org; Tue, 26 May 2009 20:28:31 -0400 Message-ID: <4A1C88A9.5080206@redhat.com> Date: Tue, 26 May 2009 20:26:17 -0400 From: john cooper MIME-Version: 1.0 References: <4A0AFE31.70908@redhat.com> <20090518121325.GA32009@infradead.org> <4A117819.5060105@redhat.com> <20090520073129.GA17378@infradead.org> In-Reply-To: <20090520073129.GA17378@infradead.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/2] Add serial number support for virtio_blk, V2 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: john.cooper@redhat.com, qemu-devel@nongnu.org, KVM list Christoph Hellwig wrote: > On Mon, May 18, 2009 at 11:00:41AM -0400, john cooper wrote: >> Christoph Hellwig wrote: >>> So why can't we re-use the existing interfaces instead of inventing a >>> new one? >> I'm unclear to what specifically you're referring -- the >> ioctl() used to retrieve the serial number in the guest? > > Well, there's not specific ioctl to get a serial number for scsi, but > given that we now have SG_IO passthrough in virtio-blk it should be easy > enough to provide inquiry data and the device identification VPD page > by that way. Not sure how it's handled for ide, maybe that way > is even easier. Yea, I'm hardly in enamored with the IDE/ATA diatribe. But in this case displacing the new ioctl with HDIO_GET_IDENTITY seemed the most straightforward means to provide access within an existing interface. Updated patch follows. -john -- john.cooper@redhat.com