From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9D6I-0005FT-3m for qemu-devel@nongnu.org; Wed, 27 May 2009 02:58:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9D6D-0005CR-B0 for qemu-devel@nongnu.org; Wed, 27 May 2009 02:58:57 -0400 Received: from [199.232.76.173] (port=43996 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9D6D-0005CA-4j for qemu-devel@nongnu.org; Wed, 27 May 2009 02:58:53 -0400 Received: from mx20.gnu.org ([199.232.41.8]:24612) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M9D6C-0003sI-Cs for qemu-devel@nongnu.org; Wed, 27 May 2009 02:58:52 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M9D69-0002MD-OW for qemu-devel@nongnu.org; Wed, 27 May 2009 02:58:50 -0400 Message-ID: <4A1CE497.4070507@web.de> Date: Wed, 27 May 2009 08:58:31 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1243335807-9495-1-git-send-email-agraf@suse.de> In-Reply-To: <1243335807-9495-1-git-send-email-agraf@suse.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig9751869F8B1DF007B5CFBEB0" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] User Networking: Enable removal of redirections List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9751869F8B1DF007B5CFBEB0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Alexander Graf wrote: > Using the new host_net_redir command you can easily create redirections= > on the fly while your VM is running. >=20 > While that's great, it's missing the removal of redirections, in case y= ou > want to have a port closed again at a later point in time. >=20 > This patch adds support for removal of redirections. Cool. I was just too lazy to hack on slirp for this so far, but now you did it. >=20 > Signed-off-by: Alexander Graf > --- > monitor.c | 5 +++-- > net.c | 43 ++++++++++++++++++++++++++++++++++++++++++- > net.h | 2 +- > slirp/libslirp.h | 1 + > slirp/slirp.c | 23 +++++++++++++++++++++++ > vl.c | 2 +- > 6 files changed, 71 insertions(+), 5 deletions(-) >=20 > diff --git a/monitor.c b/monitor.c > index 0f38c71..dbab3de 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1759,8 +1759,9 @@ static const mon_cmd_t mon_cmds[] =3D { > { "host_net_remove", "is", net_host_device_remove, > "vlan_id name", "remove host VLAN client" }, > #ifdef CONFIG_SLIRP > - { "host_net_redir", "s", net_slirp_redir, > - "[tcp|udp]:host-port:[guest-host]:guest-port", "redirect TCP or = UDP connections from host to guest (requires -net user)" }, > + { "host_net_redir", "ss?", net_slirp_redir, > + "[tcp|udp]:host-port:[guest-host]:guest-port", "redirect TCP or = UDP connections from host to guest (requires -net user)\n" If going for a single command, this should rather look like this: "[tcp|udp]:host-port:[guest-host]:guest-port | remove [tcp|udp]:host-port" BTW, I didn't refactor this interface along with the command line changes, but I should actually. To remain consistent, we should call it host_net_fwd (-redir will be replaced with hostfwd=3D) or even take= the chance and split it into host_net_fwd_add and host_net_fwd_remove. > + "host_net_redir remove [tcp:|udp:]host-port -- remove redirectio= n" }, > #endif > { "balloon", "i", do_balloon, > "target", "request VM to change it's memory allocation (in MB)" = }, Jan --------------enig9751869F8B1DF007B5CFBEB0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkoc5JwACgkQniDOoMHTA+m+hgCfZcS6uklFr3gNPWmQbiyHF4Az Lr0Ani7Oh1GKoUp4vdLFWOFszoNb4Stl =A3WV -----END PGP SIGNATURE----- --------------enig9751869F8B1DF007B5CFBEB0--