From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9DbZ-0002gx-16 for qemu-devel@nongnu.org; Wed, 27 May 2009 03:31:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9DbU-0002f8-1F for qemu-devel@nongnu.org; Wed, 27 May 2009 03:31:16 -0400 Received: from [199.232.76.173] (port=34920 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9DbT-0002ez-U4 for qemu-devel@nongnu.org; Wed, 27 May 2009 03:31:11 -0400 Received: from mx20.gnu.org ([199.232.41.8]:26793) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M9DbT-0003QC-FY for qemu-devel@nongnu.org; Wed, 27 May 2009 03:31:11 -0400 Received: from mx2.redhat.com ([66.187.237.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M9Dah-0005yX-Nw for qemu-devel@nongnu.org; Wed, 27 May 2009 03:30:24 -0400 Message-ID: <4A1CEBCC.5000307@redhat.com> Date: Wed, 27 May 2009 09:29:16 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] Patch: Adding ability for qemu-img to create SCSI VMware disk images References: <4A16D5B8.50508@codemonkey.ws> <4A1BA22D.4040008@codemonkey.ws> <4A1BB1DE.3080600@redhat.com> <4A1C487B.90908@codemonkey.ws> In-Reply-To: <4A1C487B.90908@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Aaron Mason , "qemu-devel@nongnu.org" Anthony Liguori schrieb: > Kevin Wolf wrote: >> Anthony Liguori schrieb: >> >>> Aaron Mason wrote: >>> >>>> Who said the images had to be used for QEMU? As I said, I use the >>>> utility primarily for creating VMware images. >>>> >>> If it's not useful for QEMU, then I don't see that it's worth >>> maintaining within QEMU. >>> >> Then I wonder why we have the compat6 option for VMDK. I would be rather >> surprised if it was useful for qemu itself. >> > > Yup. I don't like the compat6 patch either as it's pretty invasive. Hm, we're both talking about ec36ba1? Because I can't see how it is invasing, with the exception of the changes to qemu-img. But we don't need these any more, we have -o now. >> FWIW, I know that SUSE had a use for these SCSI VMDKs and they carry a >> local patch for it. I would prefer to have such things upstream, even if >> it's just for exporting. After all, qemu-img is the Swiss army knife for >> images. >> > > If there's support for it, we can take it. I worry about adding > features that aren't widely useful as they add complexity and make it > hard to refactor things. > > Introducing BLOCK_FLAG_BUSLOGIC and BLOCK_FLAG_LSILOGIC seems very wrong > to me. You're happy with it? No, I'm not happy with this particular patch, especially given that it doesn't apply to master any more. ;-) You said this was "not useful", so I'm just talking of the functionality, independent of the code. And code-wise, it really should be only a few lines to vmdk - which makes the create function longer by maybe five lines, but hardly more complex. Kevin