From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9EQY-0001pC-QZ for qemu-devel@nongnu.org; Wed, 27 May 2009 04:23:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9EQU-0001mz-4R for qemu-devel@nongnu.org; Wed, 27 May 2009 04:23:58 -0400 Received: from [199.232.76.173] (port=38135 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9EQU-0001ml-1a for qemu-devel@nongnu.org; Wed, 27 May 2009 04:23:54 -0400 Received: from yw-out-1718.google.com ([74.125.46.157]:58149) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M9EQT-0006G5-GP for qemu-devel@nongnu.org; Wed, 27 May 2009 04:23:53 -0400 Received: by yw-out-1718.google.com with SMTP id 5so2159158ywr.82 for ; Wed, 27 May 2009 01:23:52 -0700 (PDT) Message-ID: <4A1CF894.5010200@codemonkey.ws> Date: Wed, 27 May 2009 03:23:48 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Patch: Adding ability for qemu-img to create SCSI VMware disk images References: <4A16D5B8.50508@codemonkey.ws> <4A1BA22D.4040008@codemonkey.ws> <4A1BB1DE.3080600@redhat.com> <4A1C487B.90908@codemonkey.ws> <4A1CEBCC.5000307@redhat.com> In-Reply-To: <4A1CEBCC.5000307@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Aaron Mason , "qemu-devel@nongnu.org" Kevin Wolf wrote: > Anthony Liguori schrieb: > >> Kevin Wolf wrote: >> >>> Anthony Liguori schrieb: >>> >>> >>>> Aaron Mason wrote: >>>> >>>> >>>>> Who said the images had to be used for QEMU? As I said, I use the >>>>> utility primarily for creating VMware images. >>>>> >>>>> >>>> If it's not useful for QEMU, then I don't see that it's worth >>>> maintaining within QEMU. >>>> >>>> >>> Then I wonder why we have the compat6 option for VMDK. I would be rather >>> surprised if it was useful for qemu itself. >>> >>> >> Yup. I don't like the compat6 patch either as it's pretty invasive. >> > > Hm, we're both talking about ec36ba1? Because I can't see how it is > invasing, with the exception of the changes to qemu-img. But we don't > need these any more, we have -o now. > I find it invasive because it extends the block subsytem API with a non-generic interface. >> Introducing BLOCK_FLAG_BUSLOGIC and BLOCK_FLAG_LSILOGIC seems very wrong >> to me. You're happy with it? >> > > No, I'm not happy with this particular patch, especially given that it > doesn't apply to master any more. ;-) > > You said this was "not useful", so I'm just talking of the > functionality, independent of the code. And code-wise, it really should > be only a few lines to vmdk - which makes the create function longer by > maybe five lines, but hardly more complex. > I wouldn't mind a few line patch to vmdk's create function. Regards, Anthony Liguori > Kevin >