From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9Fkl-00087g-Bq for qemu-devel@nongnu.org; Wed, 27 May 2009 05:48:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9Fkf-000803-0M for qemu-devel@nongnu.org; Wed, 27 May 2009 05:48:54 -0400 Received: from [199.232.76.173] (port=49525 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9Fke-0007za-8R for qemu-devel@nongnu.org; Wed, 27 May 2009 05:48:48 -0400 Received: from gecko.sbs.de ([194.138.37.40]:24793) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M9Fkc-0007v6-2Y for qemu-devel@nongnu.org; Wed, 27 May 2009 05:48:47 -0400 Message-ID: <4A1D0C79.801@siemens.com> Date: Wed, 27 May 2009 11:48:41 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <2803e73b0905270229p6e5f8f3bk4a12205f5726cf6e@mail.gmail.com> <761ea48b0905270236p1da826f1t97a10fa25528acf@mail.gmail.com> In-Reply-To: <761ea48b0905270236p1da826f1t97a10fa25528acf@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: Remove qemu_alloc_physram() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Desnogues , nicolas prochazka Cc: qemu-devel@nongnu.org Laurent Desnogues wrote: > On Wed, May 27, 2009 at 11:29 AM, nicolas prochazka > wrote: >> Hello, >> Since this patch : >> http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commit;h=0e8d16ba06486ebf79f131f28121774715975248 >> Remove qemu_alloc_physram() >> Obsolete. >> >> function alloc_mem_area(memory, &map_len, mem_path); is never calling in code, >> and it seems that's -mem-path ( or -mempath) /hugepages does not >> work for me now. >> before this patch, i can see for example in /proc/meminfo : >> HugePages_Total: 2560 >> HugePages_Free: 2301 >> when i start one kvm/qemu >> >> now , HupePages_Free never down , hugepages_free = hugepages_total. > > Are you sure you're pointing at the right commit? How could the > removal of an unused function change the behavior? > I bet Nicolas is looking at qemu-kvm, right? So please post this valid question to the kvm list. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux