[Qemu-devel] [PATCH] Add static to local machine declaration.

[Qemu-devel] [PATCH] Add static to local machine declaration.

[Stefan Weil]

Variable akitapda_machine is only used locally,
so the static attribute avoids a compiler warning.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 hw/spitz.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/spitz.c b/hw/spitz.c
index aa1487b..ef0bace 100644
--- a/hw/spitz.c
+++ b/hw/spitz.c
@@ -1041,7 +1041,7 @@ static void terrier_init(ram_addr_t ram_size,
                 kernel_cmdline, initrd_filename, cpu_model, terrier,
0x33f);
 }

-QEMUMachine akitapda_machine = {
+static QEMUMachine akitapda_machine = {
     .name = "akita",
     .desc = "Akita PDA (PXA270)",
     .init = akita_init,
--
1.5.6.5

Re: [Qemu-devel] [PATCH] Add static to local machine declaration.

[Anthony Liguori]

Stefan Weil wrote:
> Variable akitapda_machine is only used locally,
> so the static attribute avoids a compiler warning.
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>   

This patch is whitespace broken as is two other patches I have in my 
queue for you.  Could you try using something like git-send-email?

Regards,

Anthony Liguori

Re: [Qemu-devel] [PATCH] Add static to local machine declaration.

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Anthony Liguori schrieb:
> Stefan Weil wrote:
>> Variable akitapda_machine is only used locally,
>> so the static attribute avoids a compiler warning.
>>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>>   
>
> This patch is whitespace broken as is two other patches I have in my
> queue for you.  Could you try using something like git-send-email?
>
> Regards,
>
> Anthony Liguori
>

Sorry, I am still a git-learner...

The appended patch will work.

Regards,

Stefan Weil


[-- Attachment #2: 0001-Add-static-to-local-machine-declaration.patch --]
[-- Type: text/x-diff, Size: 859 bytes --]

>From 3c4e4df0b882fd553aa89616e5d3d08a7eca301c Mon Sep 17 00:00:00 2001
From: Stefan Weil <weil@mail.berlios.de>
Date: Sat, 23 May 2009 23:49:14 +0200
Subject: [PATCH] Add static to local machine declaration.

Variable akitapda_machine is only used locally,
so the static attribute avoids a compiler warning.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 hw/spitz.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/spitz.c b/hw/spitz.c
index aa1487b..ef0bace 100644
--- a/hw/spitz.c
+++ b/hw/spitz.c
@@ -1041,7 +1041,7 @@ static void terrier_init(ram_addr_t ram_size,
                 kernel_cmdline, initrd_filename, cpu_model, terrier, 0x33f);
 }
 
-QEMUMachine akitapda_machine = {
+static QEMUMachine akitapda_machine = {
     .name = "akita",
     .desc = "Akita PDA (PXA270)",
     .init = akita_init,
-- 
1.5.6.5