From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M9KkN-0006ML-R1
	for qemu-devel@nongnu.org; Wed, 27 May 2009 11:08:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M9KkI-0006Jp-Vq
	for qemu-devel@nongnu.org; Wed, 27 May 2009 11:08:51 -0400
Received: from [199.232.76.173] (port=37434 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M9KkI-0006Je-J4
	for qemu-devel@nongnu.org; Wed, 27 May 2009 11:08:46 -0400
Received: from mx2.redhat.com ([66.187.237.31]:48597)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <john.cooper@redhat.com>) id 1M9KkI-0003Tr-3J
	for qemu-devel@nongnu.org; Wed, 27 May 2009 11:08:46 -0400
Message-ID: <4A1D56F2.5090207@redhat.com>
Date: Wed, 27 May 2009 11:06:26 -0400
From: john cooper <john.cooper@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk,
	V3
References: <4A1C88DE.6050608@redhat.com> <20090527074919.GB7356@lst.de>
In-Reply-To: <20090527074919.GB7356@lst.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: john.cooper@redhat.com, rusty@rustcorp.com.au, qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>

Christoph Hellwig wrote:

> This looks functionally correct, but pretty far from normal kernel coding
> style.

I tend to avoid 'goto's.

Christoph Hellwig wrote:
>> /*
>>  * IDE-compatible identify ioctl.
>>  *
>>  * Currenlyt only returns the serial number and leaves all other fields
>>  * zero.
>>  */
> 
> Btw, thinking about it the rest of the information in the ioctl should
> probably be filled up with faked data, similar to how we do it for
> the ide emulation inside qemu.

Doing so crossed my mind but thought it may be better to
start here and provide data on an as-needed basis.  But
as you point out there is precedent (and likely reason)
for hw/ide.c:ide_identify() doing as such.  I don't have
a strong bias either way.  Comments from others?

-john

-- 
john.cooper@redhat.com