From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9gm5-00047G-Er for qemu-devel@nongnu.org; Thu, 28 May 2009 10:40:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9gm0-000430-4f for qemu-devel@nongnu.org; Thu, 28 May 2009 10:40:04 -0400 Received: from [199.232.76.173] (port=42622 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9gm0-00042s-1H for qemu-devel@nongnu.org; Thu, 28 May 2009 10:40:00 -0400 Received: from rv-out-0708.google.com ([209.85.198.243]:64620) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M9glz-0006LY-Ka for qemu-devel@nongnu.org; Thu, 28 May 2009 10:39:59 -0400 Received: by rv-out-0708.google.com with SMTP id c5so1727551rvf.22 for ; Thu, 28 May 2009 07:39:58 -0700 (PDT) Message-ID: <4A1EA236.2020203@codemonkey.ws> Date: Thu, 28 May 2009 09:39:50 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/4] Split qcow2 driver References: <1243519627-525-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1243519627-525-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Mark McLoughlin , qemu-devel@nongnu.org Kevin Wolf wrote: > The current qcow2 code is a monster of 3000 lines of code. This is hardly > manageable and doesn't exactly improve the driver's structure. > > This patch series tries to split the driver in smaller modules. It doesn't > contain changes to functionality or structure, especially the latter might come > later as this series makes it much clearer what the internal interfaces used by > the qcow2 driver actually are. > > The first three patches mainly move code around. They also build up a qcow2.h > header file which contains the common structs and functions used by several > modules. Some functions need to become global to keep things compilable. > > The fourth patch cleans up the global namespace by adding a qcow2_ prefix to > all of the new global functions introduced by the first patches. > > Kevin Wolf (4): > qcow2: Split out refcount handling > qcow2: Split out guest cluster functions > qcow2: Split out snapshot functions > qcow2: Rename global functions > Could you introduce a new qcow2 directory? Perhaps add a README too that we can use to start trying to store some information about how the qcow2 driver works to help other people dive into it. I think markmc had started a document at one point, right? > Makefile | 4 +- > block/qcow2-cluster.c | 755 ++++++++++++++++++ > block/qcow2-refcount.c | 836 +++++++++++++++++++ > block/qcow2-snapshot.c | 405 ++++++++++ > block/qcow2.c | 2081 +----------------------------------------------- > block/qcow2.h | 203 +++++ > 6 files changed, 2233 insertions(+), 2051 deletions(-) > create mode 100644 block/qcow2-cluster.c > create mode 100644 block/qcow2-refcount.c > create mode 100644 block/qcow2-snapshot.c > create mode 100644 block/qcow2.h > > > > Regards, Anthony Liguori