From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9h3O-0007kW-5s for qemu-devel@nongnu.org; Thu, 28 May 2009 10:57:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9h3I-0007jp-Hi for qemu-devel@nongnu.org; Thu, 28 May 2009 10:57:56 -0400 Received: from [199.232.76.173] (port=52585 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9h3I-0007jm-DC for qemu-devel@nongnu.org; Thu, 28 May 2009 10:57:52 -0400 Received: from mx2.redhat.com ([66.187.237.31]:33344) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M9h3H-000257-Ri for qemu-devel@nongnu.org; Thu, 28 May 2009 10:57:52 -0400 Message-ID: <4A1EA62C.9060103@redhat.com> Date: Thu, 28 May 2009 16:56:44 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/4] Split qcow2 driver References: <1243519627-525-1-git-send-email-kwolf@redhat.com> <4A1EA236.2020203@codemonkey.ws> In-Reply-To: <4A1EA236.2020203@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mark McLoughlin , qemu-devel@nongnu.org Anthony Liguori schrieb: > Kevin Wolf wrote: >> The current qcow2 code is a monster of 3000 lines of code. This is hardly >> manageable and doesn't exactly improve the driver's structure. >> >> This patch series tries to split the driver in smaller modules. It doesn't >> contain changes to functionality or structure, especially the latter might come >> later as this series makes it much clearer what the internal interfaces used by >> the qcow2 driver actually are. >> >> The first three patches mainly move code around. They also build up a qcow2.h >> header file which contains the common structs and functions used by several >> modules. Some functions need to become global to keep things compilable. >> >> The fourth patch cleans up the global namespace by adding a qcow2_ prefix to >> all of the new global functions introduced by the first patches. >> >> Kevin Wolf (4): >> qcow2: Split out refcount handling >> qcow2: Split out guest cluster functions >> qcow2: Split out snapshot functions >> qcow2: Rename global functions >> > > Could you introduce a new qcow2 directory? I certainly could, but don't you think this is a bit too much? I mean, block/ isn't really crowded and if we end up having a separate directory for each file I wouldn't call this a good directory structure either. Maybe we should wait for a few other opinions and then decide if a new directory is the way to go or not. > Perhaps add a README too > that we can use to start trying to store some information about how the > qcow2 driver works to help other people dive into it. That would obviously be a different patch, but in general documentation certainly wouldn't hurt. The very first thing to document would be the image format itself, before even starting with the driver. Kevin