From: Anthony Liguori <anthony@codemonkey.ws>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/4] Split qcow2 driver
Date: Thu, 28 May 2009 10:18:57 -0500 [thread overview]
Message-ID: <4A1EAB61.10206@codemonkey.ws> (raw)
In-Reply-To: <4A1EA62C.9060103@redhat.com>
Kevin Wolf wrote:
> Anthony Liguori schrieb:
>
>> Could you introduce a new qcow2 directory?
>>
>
> I certainly could, but don't you think this is a bit too much? I mean,
> block/ isn't really crowded and if we end up having a separate directory
> for each file I wouldn't call this a good directory structure either.
>
> Maybe we should wait for a few other opinions and then decide if a new
> directory is the way to go or not.
>
Not a blocker since renaming is reasonable enough in git. Just thought
it was worth bringing up since we're talking about reorganizing code for
better maintainability...
>> Perhaps add a README too
>> that we can use to start trying to store some information about how the
>> qcow2 driver works to help other people dive into it.
>>
>
> That would obviously be a different patch, but in general documentation
> certainly wouldn't hurt. The very first thing to document would be the
> image format itself, before even starting with the driver.
>
Regards,
Anthony Liguori
> Kevin
>
next prev parent reply other threads:[~2009-05-28 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 14:07 [Qemu-devel] [PATCH 0/4] Split qcow2 driver Kevin Wolf
2009-05-28 14:07 ` [Qemu-devel] [PATCH 1/4] qcow2: Split out refcount handling Kevin Wolf
2009-05-28 14:07 ` [Qemu-devel] [PATCH 2/4] qcow2: Split out guest cluster functions Kevin Wolf
2009-05-28 14:07 ` [Qemu-devel] [PATCH 3/4] qcow2: Split out snapshot functions Kevin Wolf
2009-05-28 14:07 ` [Qemu-devel] [PATCH 4/4] qcow2: Rename global functions Kevin Wolf
2009-05-28 14:39 ` [Qemu-devel] [PATCH 0/4] Split qcow2 driver Anthony Liguori
2009-05-28 14:56 ` Kevin Wolf
2009-05-28 15:18 ` Anthony Liguori [this message]
2009-05-28 15:11 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1EAB61.10206@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).