From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9hSb-0007tA-2n for qemu-devel@nongnu.org; Thu, 28 May 2009 11:24:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9hSW-0007lm-5K for qemu-devel@nongnu.org; Thu, 28 May 2009 11:24:00 -0400 Received: from [199.232.76.173] (port=59941 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9hSV-0007lc-RZ for qemu-devel@nongnu.org; Thu, 28 May 2009 11:23:55 -0400 Received: from mx2.redhat.com ([66.187.237.31]:47974) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M9hSV-0001Z3-AJ for qemu-devel@nongnu.org; Thu, 28 May 2009 11:23:55 -0400 Message-ID: <4A1EAC49.5090006@redhat.com> Date: Thu, 28 May 2009 17:22:49 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 04/11] net: Real fix for check_params users References: <20090508103416.6080.44298.stgit@mchn012c.ww002.siemens.net> <20090508103417.6080.2193.stgit@mchn012c.ww002.siemens.net> <1243523072.4046.185.camel@blaa> In-Reply-To: <1243523072.4046.185.camel@blaa> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: Jan Kiszka , qemu-devel@nongnu.org Mark McLoughlin schrieb: > On Fri, 2009-05-08 at 12:34 +0200, Jan Kiszka wrote: >> OK, last try: ea053add70 broke -net socket, ffad4116b9 tried to fix it >> but broke error reporting of invalid parameters. So this patch widely >> reverts ffad4116b9 again and intead fixes those callers of check_params >> that originally suffered from overwritten buffers by using separate >> ones. >> >> Signed-off-by: Jan Kiszka > > Okay, I think we should revert Kevin's fix from master and replace it > with this one. Agreed. I wasn't aware of this one. Kevin