From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9hYy-00059s-Ej for qemu-devel@nongnu.org; Thu, 28 May 2009 11:30:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9hYt-000556-Px for qemu-devel@nongnu.org; Thu, 28 May 2009 11:30:35 -0400 Received: from [199.232.76.173] (port=36519 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9hYt-00054u-BZ for qemu-devel@nongnu.org; Thu, 28 May 2009 11:30:31 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.142]:39738) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M9hYt-0002Zx-1q for qemu-devel@nongnu.org; Thu, 28 May 2009 11:30:31 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e2.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n4SFOj98005719 for ; Thu, 28 May 2009 11:24:45 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4SFSxUe246142 for ; Thu, 28 May 2009 11:28:59 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4SFSt5C003130 for ; Thu, 28 May 2009 11:28:57 -0400 Message-ID: <4A1EADB4.2060106@us.ibm.com> Date: Thu, 28 May 2009 10:28:52 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1243523971.4046.206.camel@blaa> In-Reply-To: <1243523971.4046.206.camel@blaa> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: Networking patches queue List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: Jan Kiszka , qemu-devel Mark McLoughlin wrote: > Hi Anthony, > > Recently, Jan has posted 11 networking patches and I've posted 17, so I > thought I'd push out a tree with these queued up. Perhaps you want to > pull from there? > > Some notes: > > - I've taken the first 6 of Jan's patches, but left 7-11 for now; see > the review comments I just posted. I expect Jan will be able to > fix them up fairly quickly > If the first 6 patches of Jan's series are ready to apply, wouldn't it make sense for him to submit that as a separate series? In the very least, I'd like an Ack from Jan before applying his series partially. > - I've tried my best to fix up the param checking saga by reverting > Kevin's patch, going with Jan's rollback to something closer to > what was there originally and applying a small fixup patch > > - Not all of these patches are completely isolated to networking > code - e.g. the fork_exec() patch adds a SIGCHLD handler > > - I haven't reviewed the slirp changes in great detail, but they > look okay at a glance > I just got the tail end of your series before heading off on travel on Friday. It still needs review and testing. Of course, if a patches series included test cases for the functionality it was implementing, it would certainly go a far way into reducing the amount of time it took to test those patches :-) Regards, Anthony Liguori