From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9htB-0002eI-UR for qemu-devel@nongnu.org; Thu, 28 May 2009 11:51:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9ht4-0002aP-Fh for qemu-devel@nongnu.org; Thu, 28 May 2009 11:51:27 -0400 Received: from [199.232.76.173] (port=57272 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9ht4-0002a8-7j for qemu-devel@nongnu.org; Thu, 28 May 2009 11:51:22 -0400 Received: from gecko.sbs.de ([194.138.37.40]:24606) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M9ht2-0007yh-Sj for qemu-devel@nongnu.org; Thu, 28 May 2009 11:51:21 -0400 Message-ID: <4A1EB2ED.2090901@siemens.com> Date: Thu, 28 May 2009 17:51:09 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1243523971.4046.206.camel@blaa> <4A1EADB4.2060106@us.ibm.com> In-Reply-To: <4A1EADB4.2060106@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: Networking patches queue List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mark McLoughlin , Glauber Costa , qemu-devel Anthony Liguori wrote: > Mark McLoughlin wrote: >> Hi Anthony, >> >> Recently, Jan has posted 11 networking patches and I've posted 17, so I >> thought I'd push out a tree with these queued up. Perhaps you want to >> pull from there? >> >> Some notes: >> >> - I've taken the first 6 of Jan's patches, but left 7-11 for now; see >> the review comments I just posted. I expect Jan will be able to >> fix them up fairly quickly >> > > If the first 6 patches of Jan's series are ready to apply, wouldn't it > make sense for him to submit that as a separate series? In the very > least, I'd like an Ack from Jan before applying his series partially. You have the ack now. I'm very happy that Mark picks this up before it started to bitrot too much. Mark, do you plan more work in this domain in the next time? I would have no problems to route my networking related stuff through one coordinating tree, e.g. yours. Besides getting my current queue flushed I still have o rework of host_net_redir (requires coordination with Glauber) o multi-instance slirp on my agenda. And maybe more will comes once this is rolled out. > >> - I've tried my best to fix up the param checking saga by reverting >> Kevin's patch, going with Jan's rollback to something closer to >> what was there originally and applying a small fixup patch >> >> - Not all of these patches are completely isolated to networking >> code - e.g. the fork_exec() patch adds a SIGCHLD handler >> >> - I haven't reviewed the slirp changes in great detail, but they >> look okay at a glance >> > > I just got the tail end of your series before heading off on travel on > Friday. It still needs review and testing. > > Of course, if a patches series included test cases for the functionality > it was implementing, it would certainly go a far way into reducing the > amount of time it took to test those patches :-) Well, with a test framework for qemu upstream... Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux