Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel

[Jan Kiszka <jan.kiszka@siemens.com>]

Mark McLoughlin wrote:
> On Fri, 2009-05-08 at 12:34 +0200, Jan Kiszka wrote:
>> So far a couple of slirp-related parameters were expressed via
>> stand-alone command line options. This it inconsistent and unintuitive.
>> Moreover, it prevents both dynamically reconfigured (host_net_add/
>> delete) and multi-instance slirp.
>>
>> This patch refactors the configuration by turning -smb, -redir, -tftp
>> and -bootp as well as -net channel into options of "-net user". The old
>> stand-alone command line options are still processed, but no longer
>> advertised. This allows smooth migration of management applications to
>> to the new syntax and also the extension of that syntax later in this
>> series.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ....
>> diff --git a/slirp/main.h b/slirp/main.h
>> index ed51385..537c145 100644
>> --- a/slirp/main.h
>> +++ b/slirp/main.h
>> @@ -46,6 +46,8 @@ extern int tcp_keepintvl;
>>  extern uint8_t client_ethaddr[6];
>>  extern const char *slirp_special_ip;
>>  extern int slirp_restrict;
>> +extern char tftp_prefix[PATH_MAX];
>> +extern char bootp_filename[PATH_MAX];
> 
> This wouldn't build for me without including limits.h here

Please use v2 (see
http://permalink.gmane.org/gmane.comp.emulators.qemu/43080).

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux