From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9htx-0003bi-Cn for qemu-devel@nongnu.org; Thu, 28 May 2009 11:52:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9htr-0003UD-4G for qemu-devel@nongnu.org; Thu, 28 May 2009 11:52:14 -0400 Received: from [199.232.76.173] (port=57304 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9htp-0003TD-M4 for qemu-devel@nongnu.org; Thu, 28 May 2009 11:52:09 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:15889) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M9hto-0008NV-W2 for qemu-devel@nongnu.org; Thu, 28 May 2009 11:52:09 -0400 Message-ID: <4A1EB325.4090302@siemens.com> Date: Thu, 28 May 2009 17:52:05 +0200 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel References: <20090508103416.6080.44298.stgit@mchn012c.ww002.siemens.net> <20090508103418.6080.96654.stgit@mchn012c.ww002.siemens.net> <1243523221.4046.195.camel@blaa> In-Reply-To: <1243523221.4046.195.camel@blaa> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: qemu-devel@nongnu.org Mark McLoughlin wrote: > On Fri, 2009-05-08 at 12:34 +0200, Jan Kiszka wrote: >> So far a couple of slirp-related parameters were expressed via >> stand-alone command line options. This it inconsistent and unintuitive. >> Moreover, it prevents both dynamically reconfigured (host_net_add/ >> delete) and multi-instance slirp. >> >> This patch refactors the configuration by turning -smb, -redir, -tftp >> and -bootp as well as -net channel into options of "-net user". The old >> stand-alone command line options are still processed, but no longer >> advertised. This allows smooth migration of management applications to >> to the new syntax and also the extension of that syntax later in this >> series. >> >> Signed-off-by: Jan Kiszka > .... >> diff --git a/slirp/main.h b/slirp/main.h >> index ed51385..537c145 100644 >> --- a/slirp/main.h >> +++ b/slirp/main.h >> @@ -46,6 +46,8 @@ extern int tcp_keepintvl; >> extern uint8_t client_ethaddr[6]; >> extern const char *slirp_special_ip; >> extern int slirp_restrict; >> +extern char tftp_prefix[PATH_MAX]; >> +extern char bootp_filename[PATH_MAX]; > > This wouldn't build for me without including limits.h here Please use v2 (see http://permalink.gmane.org/gmane.comp.emulators.qemu/43080). Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux