From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M9hze-0006ng-Rj for qemu-devel@nongnu.org; Thu, 28 May 2009 11:58:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M9hza-0006lI-JJ for qemu-devel@nongnu.org; Thu, 28 May 2009 11:58:10 -0400 Received: from [199.232.76.173] (port=44928 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M9hza-0006lC-FW for qemu-devel@nongnu.org; Thu, 28 May 2009 11:58:06 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:48541) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M9hzZ-0001sb-Sq for qemu-devel@nongnu.org; Thu, 28 May 2009 11:58:06 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e33.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n4SFu7EP024236 for ; Thu, 28 May 2009 09:56:07 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4SFuvoU047694 for ; Thu, 28 May 2009 09:56:58 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4SFuqFj017048 for ; Thu, 28 May 2009 09:56:52 -0600 Message-ID: <4A1EB442.1060006@us.ibm.com> Date: Thu, 28 May 2009 10:56:50 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1243523971.4046.206.camel@blaa> <4A1EADB4.2060106@us.ibm.com> <1243525873.18588.11.camel@blaa> In-Reply-To: <1243525873.18588.11.camel@blaa> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: Networking patches queue List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: Jan Kiszka , qemu-devel Mark McLoughlin wrote: > On Thu, 2009-05-28 at 10:28 -0500, Anthony Liguori wrote: > >> If the first 6 patches of Jan's series are ready to apply, wouldn't it >> make sense for him to submit that as a separate series? In the very >> least, I'd like an Ack from Jan before applying his series partially. >> > > I would have thought that was one of the benefits of a clean, bisectable > patch series - that a maintainer could choose to partially apply them. > > I know when I send a patch series, I'm fully prepared for that to happen > and would much rather see them applied partially if possible, rather > than re-send the whole series. > > (Where partially means 1-N not randomly choosing a subset of patches) > I used to do that, but not everyone likes it. >> I just got the tail end of your series before heading off on travel on >> Friday. It still needs review and testing. >> > > Okay, that's perfectly reasonable. > > I got the impression you would like (at some point) to be able to have > others to act as a funnel for specific areas. I'm just testing the > water :-) > Yes, that's what I was hinting at below :-) >> Of course, if a patches series included test cases for the functionality >> it was implementing, it would certainly go a far way into reducing the >> amount of time it took to test those patches :-) >> > > That's a funny way of observing "we really should have a networking test > suite". > > Would "this tree passes kvm-autotest's networking tests" help matters? > If so, I'm sure that could be organised ... > Does kvm-autotest have networking tests? I know there's some concern about the time it takes for patches to get applied. IMHO, the best way to improve that it to get a stronger set of functional tests. I have a set I've been working on but it's on my other laptop which I cannot reach ATM :-/ As has been discussed before, I'm looking for finer grain functional tests than the installation tests that kvm-autotest is providing now. I'm not saying that this series requires submitting a test suite first, but rather that if you're interested in seeing networking advance more rapidly, a good investment would be to build out a better test infrastructure for it. Regards, Anthony Liguori