From: john cooper <john.cooper@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: john.cooper@redhat.com, Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, KVM list <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3
Date: Fri, 29 May 2009 00:04:40 -0400 [thread overview]
Message-ID: <4A1F5ED8.40402@redhat.com> (raw)
In-Reply-To: <20090527075409.GA7926@lst.de>
Christoph Hellwig wrote:
> On Wed, May 27, 2009 at 09:49:19AM +0200, Christoph Hellwig wrote:
>> /*
>> * IDE-compatible identify ioctl.
>> *
>> * Currenlyt only returns the serial number and leaves all other fields
>> * zero.
>> */
>
> Btw, thinking about it the rest of the information in the ioctl should
> probably be filled up with faked data, similar to how we do it for
> the ide emulation inside qemu.
Agreed. I've done so to the extent it makes sense
in the case of the more generic fields. A fair
amount of the identify information being generated
by hw/ide.c appears obsoleted.
-john
--
john.cooper@redhat.com
next prev parent reply other threads:[~2009-05-29 4:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 0:27 [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3 john cooper
2009-05-27 7:49 ` Christoph Hellwig
2009-05-27 7:54 ` Christoph Hellwig
2009-05-29 4:04 ` john cooper [this message]
2009-05-27 12:53 ` Rusty Russell
2009-05-29 4:05 ` john cooper
2009-05-27 15:06 ` john cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1F5ED8.40402@redhat.com \
--to=john.cooper@redhat.com \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).